Code Review

(Don't review for longer than 1 hour per session)

  • All unused "usings" are removed

    ×

    How to do this task:
    Subtasks:
  • Code is separated into correct layers (Presentation, Business, Data Layer)

    ×

    How to do this task:
    Subtasks:
  • Usage of 'out' and 'ref' keywords is avoided as recommended by Microsoft

    ×

    How to do this task:
    Subtasks:
  • Proper implementation of Exception Handling (try/catch and finally blocks) and logging of exceptions.

    ×

    How to do this task:
    Subtasks:
  • Comments are on top of all methods to describe their usage and expected input types and return type information.

    ×

    How to do this task:
    Subtasks:
  • Make sure there aren't any "Magic Numbers" in the code. Make Constants for these.

    ×

    How to do this task:
    Subtasks:
  • Sensitive information and passwords are encrypted

    ×

    How to do this task:
    Subtasks:
  • All input data is sanitized (especially user input, or exposed web service methods)

    ×

    How to do this task:
    Subtasks:
  • Confirm all database queries are using our most current accepted way of querying the database

    ×

    How to do this task:
    Subtasks:
  • Confirm resources are disposed of when not needed (file handles released when not needed, etc.)

    ×

    How to do this task:
    Subtasks:
  • The code checks for "null" whenever applicable

    ×

    How to do this task:
    Subtasks:
  • Code fragments are not duplicated when they could be pulled out into a common method/procedure (Dont Repeat Yourself) - Look for copy/pasted code as a red flag

    ×

    How to do this task:
    Subtasks:
  • Make sure reused values have one place they can be changed (Single Point Of Control)

    ×

    How to do this task:
    Subtasks:
  • Code is understandable and easily readable (are comments needed? are method names confusing? are variable names misleading?)

    ×

    How to do this task:
    Subtasks:
  • Similar values are put into Enums. (Status flags, Activity Types, Actions, etc.)

    ×

    How to do this task:
    Subtasks:
  • Check database isn't queried more than necessary. (Be suspicious of For Loops)

    ×

    How to do this task:
    Subtasks:
This checklist was created by gccook1

362 copy saved

362 copies saved